Files
money/internal/report/period.go
T
nikolaandClaude Opus 5 7d4c3eba17 Open the report on last month
The report answered for the whole index, which is the one window a spending
report is least often asked for: last January's groceries sat in the same total
as last week's, and nothing on screen said which was which. It now opens on the
month that has just ended -- the last one a statement can be complete for --
and left/right step along an axis beside the totals, from all time down through
the named windows to the oldest month the index holds.

The period narrows the report and nothing else. reloadReport runs its own query
rather than reusing the rows the transaction list is showing: the two share the
account, the search and the untagged toggle, and differ only in the date
bounds, so opening on last month must not hide the rest of the index from the
list beside it. Nothing may put the period into m.filter, which is exactly what
would make it leak.

The windows are relative to today, never to the newest statement. "Last month"
with nothing in it reports nothing and says so, because silently answering for
a month nobody asked for is worse than an empty screen; an empty period and an
empty index therefore give different messages, one asking for another period
and the other for an import. The rolling windows run to the end of this month
rather than to the last complete one -- "last 3 months" is asked in order to
see what is happening now, and leaving out the days since the 1st answers a
question nobody put. The axis is built over the whole index rather than the
rows in view, or it would grow and shrink as the account or search filter
changed and move under the cursor; a reload rebuilds it, since an import can
reach further back, but keeps the window the user was on.

s cycles how those rows are arranged: largest out first as before, then in, net
lowest first so the biggest losses lead, count, and the tag A to Z. A letter
rather than a chord because the report is not a form. The marked heading says
which column the rows are read from and the help names what the key does next,
as the rule builder's preview already does. The sort rearranges rows and never
changes which rows there are, so the order stays out of the filter for the same
reason the period does. Currency remains the outer key under every order --
there are no rates here, so two currencies interleaved by amount would invite a
comparison that cannot be made -- and every order falls back to the tag, so
ties keep a fixed position instead of reshuffling between reloads.

money report takes the same choice as --sort out|in|net|count|tag, and a
misspelt one is refused rather than silently reporting in the default order. It
keeps --month and has no equivalent of the wider windows.

store.Filter gains From and To, compared as strings because dates are stored
ISO-8601 and a string comparison is therefore a date comparison. store.Months
replaces report.Months, which nothing had ever called: the axis needs the
months of the whole index, not of a slice already in hand.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-23 15:45:23 +02:00

115 lines
3.8 KiB
Go

package report
import (
"fmt"
"time"
)
// Period is the window a report covers: an inclusive range of ISO dates, with
// either side empty for unbounded. Dates are stored as YYYY-MM-DD, so comparing
// them as strings compares them as dates and nothing has to be parsed to filter
// on one.
type Period struct {
// Label is what to call the window: "last month", "all time", "2026-06".
Label string
// Span names the dates Label stands for, because "last month" says nothing
// on its own about which month it was. Empty when the label already is the
// span, as it is for a single month and for all time.
Span string
From string
To string
}
// String names the window, and what it covers when the label does not.
func (p Period) String() string {
if p.Span == "" {
return p.Label
}
return p.Label + " · " + p.Span
}
// LastMonth is the label of the window a report opens on. The month that has
// just ended is the last one a statement can be complete for: this month is
// still filling up, so its total is not comparable with any other.
const LastMonth = "last month"
// Periods is the axis a report steps along, widest window first: the named
// ranges, then every month the index holds that is older than last month, most
// recent of those first. months is expected newest first, as store.Months
// returns it; anything in it that a named range already covers is left out of
// the tail rather than offered twice.
//
// The named ranges are relative to today, not to the newest statement. "Last
// month" means the month that has just ended, so if no statement covers it yet
// the report for it is empty — which is the honest answer, and one the user can
// act on, where silently reporting an older month they did not ask for is not.
func Periods(today time.Time, months []string) []Period {
thisMonth := time.Date(today.Year(), today.Month(), 1, 0, 0, 0, 0, time.UTC)
lastMonth := thisMonth.AddDate(0, -1, 0)
// A range ends with this month rather than with the last complete one:
// "last 3 months" is asked in order to see what is happening now, and
// leaving out the days since the 1st would answer a different question.
rolling := func(back int, label string) Period {
from := thisMonth.AddDate(0, -back, 0)
return Period{
Label: label,
Span: from.Format("2006-01") + " … " + thisMonth.Format("2006-01"),
From: isoDate(from),
To: isoDate(endOfMonth(thisMonth)),
}
}
month := func(start time.Time, label string) Period {
p := Period{Label: label, From: isoDate(start), To: isoDate(endOfMonth(start))}
if label != start.Format("2006-01") {
p.Span = start.Format("2006-01")
}
return p
}
year := time.Date(today.Year(), time.January, 1, 0, 0, 0, 0, time.UTC)
out := []Period{
{Label: "all time"},
{
Label: "this year",
Span: fmt.Sprintf("%d", today.Year()),
From: isoDate(year),
To: isoDate(year.AddDate(1, 0, -1)),
},
rolling(11, "last 12 months"),
rolling(2, "last 3 months"),
month(thisMonth, "this month"),
month(lastMonth, LastMonth),
}
cutoff := lastMonth.Format("2006-01")
for _, ym := range months {
// Months at or after last month are already on the axis above, and one
// dated in the future is a parsing bug rather than a window to offer.
if ym >= cutoff {
continue
}
start, err := time.Parse("2006-01", ym)
if err != nil {
continue
}
out = append(out, month(start, ym))
}
return out
}
// DefaultIndex is where on the axis a report opens.
func DefaultIndex(ps []Period) int {
for i, p := range ps {
if p.Label == LastMonth {
return i
}
}
return 0
}
func isoDate(t time.Time) string { return t.Format("2006-01-02") }
// endOfMonth takes the first of a month to its last day, whatever its length.
func endOfMonth(first time.Time) time.Time { return first.AddDate(0, 1, -1) }