nikola/llama_cpp
1
0
Fork 0
Code Issues Pull Requests Actions 21 Packages Projects Releases Wiki Activity

server : handle unsuccessful sink.write in chunked stream provider (#21478)

Browse Source 
Check the return value of sink.write() in the chunked content provider
and return false when the write fails, matching cpp-httplib's own
streaming contract. This prevents logging chunks as sent when the sink
rejected them and properly aborts the stream on connection failure.
This commit is contained in:
lainon1
2026-04-06 14:03:02 +02:00
committed by GitHub
parent 3979f2bb08
commit 482d862bcb
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/server/server-http.cpp
+3 -2
View File
@@ -397,8 +397,9 @@ static void process_handler_response(server_http_req_ptr && request, server_http
std::string chunk; std::string chunk;
bool has_next = response->next(chunk); bool has_next = response->next(chunk);
if (!chunk.empty()) { if (!chunk.empty()) {
// TODO: maybe handle sink.write unsuccessful? for now, we rely on is_connection_closed() if (!sink.write(chunk.data(), chunk.size())) {
sink.write(chunk.data(), chunk.size()); return false;
}
SRV_DBG("http: streamed chunk: %s\n", chunk.c_str()); SRV_DBG("http: streamed chunk: %s\n", chunk.c_str());
} }
if (!has_next) { if (!has_next) {